fix(workflow): expose POEDITOR_TOKEN to locale audit step#8203
Merged
fix(workflow): expose POEDITOR_TOKEN to locale audit step#8203
Conversation
…t-only mode Co-authored-by: DawoudIO <554959+DawoudIO@users.noreply.github.com>
DawoudIO
requested review from
DAcodedBEAT,
DawoudIO,
MrClever,
bigtigerku,
Copilot,
grayeul and
respencer
and removed request for
a team
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions workflow job for locale audit
fix(workflow): expose POEDITOR_TOKEN to locale audit step
Mar 6, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a failing GitHub Actions workflow (locale-poeditor-download.yml) where the Run locale audit step failed because npm run locale:audit reads process.env.POEDITOR_TOKEN but the secret was not exported to that step's environment. The fix promotes the token to a job-level env variable so all steps (including Run locale audit) automatically inherit it, removes the now-redundant step-level env on the Download locales from POEditor step, and removes the audit-only bypass on the Check POEditor Token step to ensure the token is always validated (since audit-only mode also calls the POEditor API).
Changes:
- Moved
POEDITOR_TOKENsecret to job-levelenv, making it available to all steps includingRun locale audit - Removed the
if: inputs.operation_mode != 'audit-only'guard from theCheck POEditor Tokenstep so token validation runs in every mode - Removed the now-redundant step-level
envblock from theDownload locales from POEditorstep
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Run locale auditstep lackedPOEDITOR_TOKENin its environment, causingnpm run locale:auditto always fail withPOEDITOR_TOKEN environment variable is required. Additionally,audit-onlymode skipped the token presence check despite the audit script requiring the token to call the POEditor API.Changes
env: MovedPOEDITOR_TOKEN: ${{ secrets.POEDITOR_TOKEN }}from the download step to the job level, making it available to all steps includingRun locale auditif: inputs.operation_mode != 'audit-only'guard fromCheck POEditor Token— the check is required for all modes since the audit calls the POEditor APIenvblock fromDownload locales from POEditorOriginal prompt
This pull request was created from Copilot chat.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.